From: Taylor Blau <me@ttaylorr.com>
Date: Wed, 11 Oct 2023 19:16:24 GMT
Subject: Re: [PATCH 19/20] commit-graph: detect out-of-order BIDX offsets
Message-ID: <ZSb0iCFxYL3nymvJ@nand.local>
In-Reply-To: <20231009210556.GS3282181@coredump.intra.peff.net>

On Mon, Oct 09, 2023 at 05:05:56PM -0400, Jeff King wrote:
> diff --git a/bloom.c b/bloom.c
> index 61abad7f8c..1474aa19fa 100644
> --- a/bloom.c
> +++ b/bloom.c
> @@ -75,6 +75,16 @@ static int load_bloom_filter_from_graph(struct commit_graph *g,
>  	    check_bloom_offset(g, lex_pos - 1, start_index) < 0)
>  		return 0;
>
> +	if (end_index < start_index) {
> +		warning("ignoring decreasing changed-path index offsets"
> +			" (%"PRIuMAX" > %"PRIuMAX") for positions"
> +			" %"PRIuMAX" and %"PRIuMAX" of %s",

Should this be marked for translation?

Otherwise this LGTM.

Thanks,
Taylor