From: Taylor Blau <me@ttaylorr.com>
Date: Tue, 10 Oct 2023 23:47:25 GMT
Subject: Re: [PATCH 02/20] t: add library for munging chunk-format files
Message-ID: <ZSXijWNVCyO7FelP@nand.local>
In-Reply-To: <20231009205838.GB3282181@coredump.intra.peff.net>

On Mon, Oct 09, 2023 at 04:58:38PM -0400, Jeff King wrote:
> ---
>  t/lib-chunk.sh                    | 17 ++++++++
>  t/lib-chunk/corrupt-chunk-file.pl | 66 +++++++++++++++++++++++++++++++
>  2 files changed, 83 insertions(+)
>  create mode 100644 t/lib-chunk.sh
>  create mode 100644 t/lib-chunk/corrupt-chunk-file.pl

I can't claim to be a competent reviewer for the Perl portions of this
patch. But I agree with the goal and am glad to see us getting away from
the brittle implementation that we have been living with in the test
suite.

Thanks,
Taylor