From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Date: Tue, 26 Sep 2023 08:48:07 GMT
Subject: Re: [PATCH v2 3/3] pkt-line: do not chomp newlines for sideband messages
Message-ID: <ZRKax7Me5uIHKHoC@ugly>
In-Reply-To: <xmqqa5t9rkft.fsf@gitster.g>

>Jiang Xin <worldhello.net@gmail.com> writes:
>
>> +++ b/pkt-line.c
>> @@ -462,8 +462,33 @@ enum packet_read_status packet_read_with_status(int fd, char **src_buffer,
>>  	}
>> +			case 2:
>> +				/* fallthrough */
>> +			case 3:
>
while not entirely unprecedented, it's unnecessary and even 
counter-productive to annotate directly adjacent cases with fallthrough.

regards