From: Taylor Blau <me@ttaylorr.com>
Date: Fri, 15 Sep 2023 18:29:38 GMT
Subject: Re: [PATCH 1/2] http: factor out matching of curl http/2 trace lines
Message-ID: <ZQSikid1kgbjCDJV@nand.local>
In-Reply-To: <20230915113316.GA3531587@coredump.intra.peff.net>

On Fri, Sep 15, 2023 at 07:33:16AM -0400, Jeff King wrote:
> We have to parse out curl's http/2 trace lines so we can redact their
> headers. We already match two different types of lines from various
> vintages of curl. In preparation for adding another (which will be
> slightly more complex), let's pull the matching into its own function,
> rather than doing it in the middle of a conditional.
>
> While we're doing so, let's expand the comment a bit to describe the two
> matches. That probably should have been part of db30130165 (http: handle
> both "h2" and "h2h3" in curl info lines, 2023-06-17), but will become
> even more important as we add new types.
>
> Signed-off-by: Jeff King <peff@peff.net>

Makes sense, and this sets us up well for the next step in fixing the
test fallout from newer versions of curl.

Thanks,
Taylor