From: Taylor Blau <me@ttaylorr.com>
Date: Wed, 09 Aug 2023 21:18:52 GMT
Subject: Re: [PATCH v4 2/8] t/helper: add 'find-pack' test-tool
Message-ID: <ZNQCvEJif4/VooyD@nand.local>
In-Reply-To: <20230808082608.582319-3-christian.couder@gmail.com>

On Tue, Aug 08, 2023 at 10:26:02AM +0200, Christian Couder wrote:
> +	if (count > -1 && count != actual_count)
> +		die ("bad packfile count %d instead of %d", actual_count, count);

I think there is an extra space between "die" and the opening
parenthesis. But obviously not worth a reroll here.

> diff --git a/t/t0080-find-pack.sh b/t/t0080-find-pack.sh
> new file mode 100755
> index 0000000000..67b11216a3
> --- /dev/null
> +++ b/t/t0080-find-pack.sh
> @@ -0,0 +1,82 @@

These new tests look great, thanks for adding them :-).

Thanks,
Taylor