From: Taylor Blau <me@ttaylorr.com>
Date: Mon, 03 Jul 2023 17:07:52 GMT
Subject: Re: [PATCH v4 02/16] ref-filter.h: provide `REF_FILTER_INIT`
Message-ID: <ZKMAaI3I7NDDatXk@nand.local>
In-Reply-To: <20230703051504.GB3502534@coredump.intra.peff.net>

On Mon, Jul 03, 2023 at 01:15:04AM -0400, Jeff King wrote:
> > In the meantime, fix a case in test-reach.c where its `ref_filter` is
> > not even zero-initialized.
>
> This test-reach case scared me, but it happens to work now because
> commit_contains() only looks at the one field that we set. So we're not
> fixing a bug, but more like a bug waiting to happen. :)

Good point, I updated the commit message to more clearly signal that
this isn't fixing a bug, but rather preventing one.

Thanks,
Taylor