From: Taylor Blau Date: Wed, 03 May 2023 22:08:29 GMT Subject: Re: [PATCH 1/3] revision: support tracking uninteresting commits Message-ID: In-Reply-To: <0b8884ea-f37b-b7d4-6edb-825ca935a893@github.com> On Tue, Apr 25, 2023 at 02:15:49PM -0400, Derrick Stolee wrote: > I know that the walking code in builtin/pack-objects.c does > this same computation, but it's muddled with other checks and > the trees are marked as UNINTERESTING at the same time. It > doesn't seem like we can reuse anything directly out of there, > but it did give me the idea to try a callback. Interesting idea. When you say callback, do you mean a function that we invoke in place of where we currently call `add_object_array()`? Or do you mean something else? Curious. Thanks, Taylor