From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Date: Thu, 23 Mar 2023 21:10:44 GMT
Subject: Re: [PATCH 1/3] Capitalization and punctuation fixes to some user visible messages
Message-ID: <ZBzAVMCOadgE1sa8@ugly>
In-Reply-To: <xmqqttyb6w3j.fsf@gitster.g>

On Thu, Mar 23, 2023 at 01:39:28PM -0700, Junio C Hamano wrote:
>Oswald Buddenhagen <oswald.buddenhagen@gmx.de> writes:
>
>>  			require_clean_work_tree(the_repository,
>>  				N_("pull with rebase"),
>> -				_("please commit or stash them."), 1, 0);
>> +				_("Please commit or stash them."), 1, 0);
>
>Our friendly CodingGuidelines is fairly clear on what to do to a
>single sentence error message like this one: [...]
>
i know. that's why the commit message makes a point of stating that it's 
making an exception.

the reasoning is basically that it's not *really* an error message, it's 
just abusing the machinery. you obviously noticed that yourself, 
suggesting to turn these strings into advice messages. but that kinda 
feels like overkill to me.