From: Taylor Blau <me@ttaylorr.com>
Date: Wed, 19 Mar 2025 22:27:38 GMT
Subject: Re: [PATCH v3 3/3] treewide: replace assert() with ASSERT() in special cases
Message-ID: <Z9tE2rQxT+qQP2mh@nand.local>
In-Reply-To: <82b7344e96683efdac5dfc559a023d81ea0084d0.1742401378.git.gitgitgadget@gmail.com>

On Wed, Mar 19, 2025 at 04:22:58PM +0000, Elijah Newren via GitGitGadget wrote:
> From: Elijah Newren <newren@gmail.com>
>
> When the compiler/linker cannot verify that an assert() invocation is
> free of side effects for us (e.g. because the assertion includes some
> kind of function call), replace the use of assert() with ASSERT().

As a nice side-benefit, since our new ASSERT() macro naturally has the
same number of characters as a bog-standard assert(), we don't have to
realign any multi-line assertions below ;-).

Thanks,
Taylor