From: Patrick Steinhardt <ps@pks.im>
Date: Wed, 05 Feb 2025 07:03:33 GMT
Subject: Re: What's cooking in git.git (Feb 2025, #01; Tue, 4)
Message-ID: <Z6MNRVrhw3Nxz6Iw@pks.im>
In-Reply-To: <xmqqldulrvly.fsf@gitster.g>

On Tue, Feb 04, 2025 at 06:08:57PM -0800, Junio C Hamano wrote:
> * tc/clone-single-revision (2025-02-04) 7 commits
>  - builtin/clone: teach git-clone(1) the --revision= option
>  - parse-options: introduce die_for_incompatible_opt2()
>  - clone: introduce struct clone_opts in builtin/clone.c
>  - clone: add tags refspec earlier to fetch refspec
>  - clone: refactor wanted_peer_refs()
>  - clone: make it possible to specify --tags
>  - clone: cut down on global variables in clone.c
> 
>  "git clone" learned to make a shallow clone for a single commit
>  that is not necessarily be at the tip of any branch.
> 
>  Will merge to 'next'?
>  source: <20250204-toon-clone-refs-v5-0-37e34af283c8@iotcl.com>

I'll do another review today.

> * ps/reftable-sans-compat-util (2025-02-03) 19 commits
>  - Makefile: skip reftable library for Coccinelle
>  - reftable: decouple from Git codebase by pulling in "compat/posix.h"
>  - git-compat-util.h: split out POSIX-emulating bits
>  - compat/mingw: split out POSIX-related bits
>  - reftable/basics: stop using `UNUSED` annotation
>  - reftable/basics: stop using `SWAP()` macro
>  - reftable/stack: stop using `sleep_millisec()`
>  - reftable/system: introduce `reftable_rand()`
>  - reftable/reader: stop using `ARRAY_SIZE()` macro
>  - reftable/basics: provide wrappers for big endian conversion
>  - reftable/basics: stop using `st_mult()` in array allocators
>  - reftable: stop using `BUG()` in trivial cases
>  - reftable/record: don't `BUG()` in `reftable_record_cmp()`
>  - reftable/record: stop using `BUG()` in `reftable_record_init()`
>  - reftable/record: stop using `COPY_ARRAY()`
>  - reftable/blocksource: stop using `xmmap()`
>  - reftable/stack: stop using `write_in_full()`
>  - reftable/stack: stop using `read_in_full()`
>  - Merge branch 'ps/reftable-sign-compare' into ps/reftable-sans-compat-util
> 
>  Make the code in reftable library less reliant on the service
>  routines it used to borrow from Git proper, to make it easier to
>  use by external users of the library.
> 
>  Will merge to 'next'?
>  source: <20250203-pks-reftable-drop-git-compat-util-v3-0-446c9ed4ee9e@pks.im>

From my POV it's ready, but I'd like to get an Ack from Justin and
Johannes, as they both had comments on the last round. I've Cc'd them.

> * kn/reflog-migration-fix-followup (2025-01-22) 4 commits
>  - reftable: prevent 'update_index' changes after adding records
>  - refs: use 'uint64_t' for 'ref_update.index'
>  - refs: mark `ref_transaction_update_reflog()` as static
>  - Merge branch 'kn/reflog-migration-fix' into kn/reflog-migration-fix-followup
> 
>  Code clean-up.
> 
>  On hold.
>  cf. <Z5DgxQuc2j_-5GHg@pks.im>
>  source: <20250122-461-corrupted-reftable-followup-v3-0-ae5f88bf04fa@gmail.com>

I think this topic should now be unblocked as all the preceding fixes
and fixes of fixes have been merged.

> * bf/fetch-set-head-fix (2025-01-27) 2 commits
>  - fetch set_head: fix non-mirror remotes in bare repositories
>  - fetch set_head: refactor to use remote directly
> 
>  Fetching into a bare repository incorrectly assumed it always used
>  a mirror layout when deciding to update remote-tracking HEAD, which
>  has been corrected.
> 
>  Will merge to 'next'?
>  source: <Z5Mrk02wMdABtrVZ@pks.im>

Yup, I think this series is ready.

> * ds/backfill (2025-02-03) 7 commits
>  - backfill: assume --sparse when sparse-checkout is enabled
>  - backfill: add --sparse option
>  - backfill: add --min-batch-size=<n> option
>  - backfill: basic functionality and tests
>  - backfill: add builtin boilerplate
>  - Merge branch 'master' into ds/backfill
>  - Merge branch 'ds/path-walk-1' into ds/backfill
> 
>  Lazy-loading missing files in a blobless clone on demand is costly
>  as it tends to be one-blob-at-a-time.  "git backfill" is introduced
>  to help bulk-download necessary files beforehand.
> 
>  Will merge to 'next'?
>  source: <pull.1820.v3.git.1738602667.gitgitgadget@gmail.com>

I'll do another review today, but think it should be close or ready.

> * ps/send-pack-unhide-error-in-atomic-push (2025-02-03) 8 commits
>  - send-pack: gracefully close the connection for atomic push
>  - t5543: atomic push reports exit code failure
>  - send-pack: new return code "ERROR_SEND_PACK_BAD_REF_STATUS"
>  - t5548: add porcelain push test cases for dry-run mode
>  - t5548: add new porcelain test cases
>  - t5548: refactor test cases by resetting upstream
>  - t5548: refactor to reuse setup_upstream() function
>  - t5504: modernize test by moving heredocs into test bodies
> 
>  "git push --atomic --porcelain" used to ignore failures from the
>  other side, losing the error status from the child process, which
>  has been corrected.
> 
>  Will merge to 'next'?
>  source: <20250203-pks-push-atomic-respect-exit-code-v5-0-d66481e36622@pks.im>

I think so.

One topic that I miss in the cover letter is [1]. You probably forgot to
pick it up :)

Thank you, as always!

[1]: <20250125-b4-pks-reftable-win32-in-use-errors-v1-1-356dbc783b4f@pks.im>

Patrick