From: Patrick Steinhardt <ps@pks.im>
Date: Mon, 27 Jan 2025 07:30:16 GMT
Subject: Re: [PATCH v2 2/2] fetch set_head: fix non-mirror remotes in bare repositories
Message-ID: <Z5c2CKpYM3KevMyD@pks.im>
In-Reply-To: <20250126220403.289742-2-bence@ferdinandy.com>

On Sun, Jan 26, 2025 at 11:02:11PM +0100, Bence Ferdinandy wrote:
> In b1b713f722 (fetch set_head: handle mirrored bare repositories,
> 2024-11-22) it was implicitly assumed that all remotes will be mirrors
> in a bare repository, thus fetching a non-mirrored remote could lead to
> HEAD pointing to a non-existent reference. Make sure we only overwrite
> HEAD if we are in a bare repository and fetching from a mirror.
> Otherwise, proceed as normally, and create
> refs/remotes/<nonmirrorremote>/HEAD instead.
> 
> Reported-by: Christian Hesse <list@eworm.de>
> Signed-off-by: Bence Ferdinandy <bence@ferdinandy.com>

Thanks, both of these patches look sensible to me.

Patrick