From: Patrick Steinhardt <ps@pks.im>
Date: Mon, 27 Jan 2025 07:26:25 GMT
Subject: Re: [PATCH v3 4/4] commit.c: Fix type conversation warnings from msvc
Message-ID: <Z5c1ITUkNqB7CeHW@pks.im>
In-Reply-To: <20250126130038.3277-1-soekkle@freenet.de>

On Sun, Jan 26, 2025 at 02:00:38PM +0100, Sören Krecker wrote:
> diff --git a/commit.c b/commit.c
> index 540660359d..c9cc56bd9f 100644
> --- a/commit.c
> +++ b/commit.c
> @@ -1530,7 +1530,7 @@ int commit_tree(const char *msg, size_t msg_len, const struct object_id *tree,
>  	return result;
>  }
>  
> -static int find_invalid_utf8(const char *buf, int len)
> +static int find_invalid_utf8(const char *buf, size_t len)
>  {
>  	int offset = 0;

Shouldn't the type of `offset` be adjusted, as well?

Patrick