From: Patrick Steinhardt <ps@pks.im>
Date: Fri, 17 Jan 2025 09:46:49 GMT
Subject: Re: [PATCH v2 5/5] pack-write: pass hash_algo to internal functions
Message-ID: <Z4onCYz5zD0L1_Q-@pks.im>
In-Reply-To: <20250117-kn-the-repo-cleanup-v2-5-a7fdc19688f5@gmail.com>

On Fri, Jan 17, 2025 at 10:20:52AM +0100, Karthik Nayak wrote:
> The internal functions `write_rev_trailer()`, `write_rev_trailer()`,
> `write_mtimes_header()` and write_mtimes_trailer()` use the global
> `the_hash_algo` variable to access the repository's hash function. Pass
> the hash from down as we've added made them available in the previous

This doesn't read quite right -- from where do we want to pass it down?
Other than that the series looks good to me, thanks!

Patrick