From: Patrick Steinhardt <ps@pks.im>
Date: Tue, 10 Dec 2024 11:56:38 GMT
Subject: Re: [PATCH 3/4] ci/lib: use echo instead of printf to set up sections
Message-ID: <Z1gscPivAADEvMGI@pks.im>
In-Reply-To: <Z1QRp8jFJPYdNmQk@ugly>

On Sat, Dec 07, 2024 at 10:13:11AM +0100, Oswald Buddenhagen wrote:
> On Fri, Dec 06, 2024 at 12:10:15PM +0100, Patrick Steinhardt wrote:
> > We use printf to set up sections with GitLab CI even though we could
> > trivially use echo.
> > 
> probably not a good idea, because the file is also included from plain
> sh scripts, which may invoke an `echo` that cannot deal with \escapes.
> at least potentially.

Ah, true.

> > This may cause problems in case the argument passed to `begin_group ()`
> > or `end_group ()` contains formatting directives as we use them as part
> > of the formatting string.
> > 
> that can be fixed properly by using the %s expando.

Yup, will do. Thanks!

Patrick