From: Patrick Steinhardt <ps@pks.im>
Date: Fri, 06 Dec 2024 15:45:30 GMT
Subject: Re: [PATCH v2] object-name: fix reversed ordering with ":/<PATTERN>" revisions
Message-ID: <Z1McGsD8nG5x43g9@pks.im>
In-Reply-To: <4fc44fe4-cf34-4b6b-a073-8ad5b02fe663@app.fastmail.com>

On Fri, Dec 06, 2024 at 03:33:52PM +0100, Kristoffer Haugsbakk wrote:
> On Fri, Dec 6, 2024, at 13:28, Patrick Steinhardt wrote:
> > Recently it was reported [1] that "look for the youngest reachable
> > commit with log message that match the given pattern" syntax (e.g.
> > ':/<PATTERN>' or 'HEAD^{/<PATTERN>}') started to return results in
> 
> But the regression is only for `:/`.  Not for `HEAD^{/}`.  I’m sorry
> that I wasn’t clear in my previous message[1] since I didn’t establish
> the context properly:
> 
>     I have indeed noticed that `HEAD^{/}` returns a sensible thing while
>     `:/` does something strange like finding the root commit.
> 
> What I had noticed myself for a little while was that `HEAD^{/}` on
> Git 2.47.0 did something that I wanted (and which is documented) while
> `:/` behaved (behaves) weirdly.  I just shrugged that off since the
> second syntax is more useful anyway (like Junio said).
> 
> 🔗 1: https://lore.kernel.org/git/Z1LtS-8f8WZyobz3@pks.im/T/#m0b68bb083d5ec6fddbc2af2ec5886a7a884d27ad

Fair, I should've double checked. Anyway, verifying the behaviour of
both in the added test is probably still sensible.

Thanks!

Patrick