From: Patrick Steinhardt <ps@pks.im>
Date: Mon, 31 Mar 2025 07:38:31 GMT
Subject: Re: [GSoC PATCH v3] userdiff: add builtin driver for INI files
Message-ID: <Z-pGdyh0eG3xSe4W@pks.im>
In-Reply-To: <20250331031309.94682-1-lucasseikioshiro@gmail.com>

On Mon, Mar 31, 2025 at 12:13:09AM -0300, Lucas Seiki Oshiro wrote:
> Add a new builtin driver for generic INI files (e. g. the gitconfig
> files), where:
> 
> - the funcname regular expression matches section names, i. e. any
>   string between brackets at the beginning of the line, with or without
>   indentation;
> 
> - word_regex matches any word with one or more non-whitespace
>   characters without checking if it is a valid variable name or value.
> 
> Also add tests for the new userdiff driver. These files define sections
> and subsections, with and without indentation.
> 
> Helped-by: Patrick Steinhardt <ps@pks.im>
> Helped-by: D. Ben Knoble <ben.knoble@gmail.com>
> Signed-off-by: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>

This commit message reads quite nicely now. The changes also look
sensible to me. Thanks, I've got nothing else to add!

Patrick