From: Patrick Steinhardt Date: Fri, 28 Mar 2025 09:24:13 GMT Subject: Re: [PATCH v5 0/8] refs: introduce support for batched reference updates Message-ID: In-Reply-To: <20250327-245-partially-atomic-ref-updates-v5-0-4db2a3e34404@gmail.com> On Thu, Mar 27, 2025 at 12:13:24PM +0100, Karthik Nayak wrote: > Changes in v5: > - Inline the comments around the 'ref_transaction_error'. > - Use 'strbuf_reset()' wherever possible instead of 'strbuf_setlen(err, 0)'. > - Use an extra 'conflicting_dirnames' strset in 'refs_verify_refnames_available()' to track > dirnames which were found to be conflicting, this is to avoid re-reading those dirnames. > - Add curly braces style mismatch in if..else block. > - Link to v4: https://lore.kernel.org/r/20250320-245-partially-atomic-ref-updates-v4-0-3dcc1b311dc9@gmail.com Thanks, the series looks good to me judging by the range diff. Patrick