From: Patrick Steinhardt <ps@pks.im>
Date: Thu, 27 Mar 2025 10:19:25 GMT
Subject: Re: [PATCH v2 11/20] t: refactor tests depending on Perl substitution operator
Message-ID: <Z-UmLWcMgW2f9970@pks.im>
In-Reply-To: <198d1d40-ea1f-4362-821c-2cc621892e4e@gmail.com>

On Tue, Mar 25, 2025 at 02:35:52PM +0000, Phillip Wood wrote:
> Hi Patrick
> 
> On 25/03/2025 13:14, Patrick Steinhardt wrote:
> >   broken_c_unquote () {
> > -	"$PERL_PATH" -pe 's/^"//; s/\\//; s/"$//; tr/\n/\0/' "$@"
> > +	sed -e 's/^"//' -e 's/\\//' -e 's/"$//' "$1" | tr '\n' '\0'
> >   }
> >   broken_c_unquote_verbose () {
> > -	"$PERL_PATH" -pe 's/	"/	/; s/\\//; s/"$//; tr/:\t\n/\0/' "$@"
> > +	sed -e 's/	"/	/' -e 's/\\//' -e 's/"$//' "$1" | tr ':\t\n' '\000'
> >   }
> 
> Thanks for removing the redirection here, unfortunately there are still a
> whole bunch of needless input redirections below.

Fair. I've scanned through all commits now and replaced every use of
such redirects. Will send out that version soonish.

Patrick