From: Patrick Steinhardt <ps@pks.im>
Date: Wed, 26 Mar 2025 05:54:50 GMT
Subject: Re: [PATCH v2 00/10] Avoid the comma operator
Message-ID: <Z-OWqs33rcgbYcR8@pks.im>
In-Reply-To: <pull.1889.v2.git.1742945534.gitgitgadget@gmail.com>

On Tue, Mar 25, 2025 at 11:32:04PM +0000, Johannes Schindelin via GitGitGadget wrote:
> The comma operator
> [https://en.cppreference.com/w/c/language/operator_other#Comma_operator] is
> rarely used in C anymore, and typically indicates a typo. Just like in these
> instances, where a semicolon was meant to be used, as there is no need to
> discard the first statement's result here.
> 
> Changes since v1:
> 
>  * Use -Wcomma when compiling with clang and with DEVELOPER=1.
>  * Address the remaining instances pointed out by clang (and by Phillip).

Thanks for all of these fixes!

Patrick