From: Patrick Steinhardt <ps@pks.im>
Date: Wed, 26 Mar 2025 05:54:33 GMT
Subject: Re: [PATCH v2 04/10] clar: avoid using the comma operator unnecessarily
Message-ID: <Z-OWmSe3vCDaZLXy@pks.im>
In-Reply-To: <f60ebe376e10d7741f6bd657874a17f6c09d4477.1742945534.git.gitgitgadget@gmail.com>

On Tue, Mar 25, 2025 at 11:32:08PM +0000, Johannes Schindelin via GitGitGadget wrote:
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
> 
> The comma operator is a somewhat obscure C feature that is often used by
> mistake and can even cause unintentional code flow. In this instance, it
> makes the code harder to read than necessary, too. Better use a
> semicolon instead.

This code has changed upstream already, but let's roll with your change
anyway. I plan to update the clar to the upstream version soonish once I
have landed integer comparisons, and will take care that there aren't
any other comment operators left.

Patrick