From: Jeff King <peff@peff.net>
Date: Wed, 05 Oct 2022 14:53:50 GMT
Subject: Re: [PATCH] git-compat-util.h: GCC deprecated only takes a message in GCC 4.5+
Message-ID: <Yz2afjRezq5oGN4g@coredump.intra.peff.net>
In-Reply-To: <CAOO-Oz2WnodBnw86mi2GZ+jLGoGy_saX=kCpwPdm2xohDO1s_Q@mail.gmail.com>

On Mon, Oct 03, 2022 at 07:45:44PM -0400, Alejandro R. Sedeño wrote:

> I'm targeting an old SunOS 5.10 with a GCC 3.4.3, for reasons that can
> only be described as self-loathing. :-)
> The other users of GIT_GNUC_PREREQ are used for 2.8, and 3.1, so I
> figure distinguishing between 4.5+ and <4.5 should be well supported.
> 
> Regardless, there's no reason to break older compilers over something
> that's this trivial to fix.

This will cause some mild hardships, as later patches will need to
#define UNUSED in other spots, as well, in order to get full coverage of
the code base (I have written those annotation patches, but they're not
applied upstream yet).

Still, I tend to agree with you that we should handle this case. It's
not too much work, and I should be able to work around the multiple
definitions by pulling it out into an unused.h or similar.

-Peff