From: Denton Liu Date: Thu, 08 Sep 2022 02:44:04 GMT Subject: Re: [PATCH v2 7/7] rebase --keep-base: imply --no-fork-point Message-ID: In-Reply-To: <6410b101d7f4ad97f87faec93703370a0493aa4a.1662561470.git.gitgitgadget@gmail.com> Hi Phillip, Sorry I haven't been active in Git development lately. I've been busy with other stuff. I was skimming my emails and this patch caught my eye. On Wed, Sep 07, 2022 at 02:37:50PM +0000, Phillip Wood via GitGitGadget wrote: > diff --git a/t/t3431-rebase-fork-point.sh b/t/t3431-rebase-fork-point.sh > index 1d0b15380ed..70e81363569 100755 > --- a/t/t3431-rebase-fork-point.sh > +++ b/t/t3431-rebase-fork-point.sh > @@ -50,7 +50,7 @@ test_rebase () { > > test_rebase 'G F E D B A' > test_rebase 'G F D B A' --onto D > -test_rebase 'G F B A' --keep-base > +test_rebase 'G F C B A' --keep-base We should add a test here for explicit --fork-point just to ensure that the behaviour stays the same in case anyone relies on it here. > test_rebase 'G F C E D B A' --no-fork-point > test_rebase 'G F C D B A' --no-fork-point --onto D > test_rebase 'G F C B A' --no-fork-point --keep-base > -- > gitgitgadget