From: Taylor Blau <me@ttaylorr.com>
Date: Mon, 22 Aug 2022 19:44:00 GMT
Subject: Re: [PATCH 0/6] midx: permit changing the preferred pack when reusing the MIDX
Message-ID: <YwPcgIStTEelWJfK@nand.local>
In-Reply-To: <6c146fa9-48da-5f74-c91a-29c54e1da6ce@github.com>

On Mon, Aug 22, 2022 at 01:04:29PM -0400, Derrick Stolee wrote:
> Thanks for putting this together. Definitely not an easy bug to find
> and fix.
>
> I mostly have nitpicks, but the overall structure is sound.

Thanks very much for reviewing (both to you and Abhradeep). I have a new
version that I'll send now, which incorporates your suggestions.

It also adds a new patch on top that takes a slight optimization, by
avoiding adding objects from the MIDX that show up in the (new)
preferred pack, since we know we'll discard them anyway.

Thanks,
Taylor