From: Jeff King <peff@peff.net>
Date: Fri, 29 Jul 2022 19:02:25 GMT
Subject: Re: [PATCH v2 0/6] revisions API: fix more memory leaks
Message-ID: <YuQuwVRNrgfWB7SY@coredump.intra.peff.net>
In-Reply-To: <cover-v2-0.6-00000000000-20220729T082919Z-avarab@gmail.com>

On Fri, Jul 29, 2022 at 10:31:02AM +0200, Ævar Arnfjörð Bjarmason wrote:

> A late re-roll of this set of revisions API and API user memory leak
> fixes. I think the much simpler code here in 4/6 should address the
> points Jeff King brought up in the v1 review.
> 
> Other than that I renamed the variable in 3/6 s/cp/pending/g, per
> Jeff's suggestion (FWIW "cp" = "copy").

Thanks (and for the explanation regarding t91xx; I did totally miss in
the v1 review that those were removing "FAIL" lines, not "PASS" ones).

I don't think there's anything incorrect here, but I did make a few
cosmetic / explanation suggestions.

-Peff