From: Taylor Blau <me@ttaylorr.com>
Date: Fri, 20 May 2022 22:39:23 GMT
Subject: Re: [PATCH v4 12/17] builtin/repack.c: support generating a cruft pack
Message-ID: <YogYm50szub90Ift@nand.local>
In-Reply-To: <220519.86v8u14v52.gmgdl@evledraar.gmail.com>

On Thu, May 19, 2022 at 01:29:26PM +0200, Ævar Arnfjörð Bjarmason wrote:
>
> On Wed, May 18 2022, Taylor Blau wrote:
>
> > +		tip="$(git rev-parse cruft)" &&
>
> Here we don't hide the exit status of "git", as it'll be reflected in what's &&-chained.

Oops! Nice catch.

> > +		path="$objdir/$(test_oid_to_path "$(git rev-parse cruft)")" &&
>
> But here we do, as we'll get the exit status of test_oid_to_path. But as
> we just rev parsed it shouldn't this be $tip in any case?

Indeed, this can just be:

    path="$objdir/$(test_oid_to_path "$tip")" &&

Will include in a reroll shortly.

Thanks,
Taylor