From: Taylor Blau <me@ttaylorr.com>
Date: Wed, 26 Jan 2022 20:19:45 GMT
Subject: Re: [PATCH v4 5/9] t5326: extract `test_rev_exists`
Message-ID: <YfGs4WG+S9f4/eqW@nand.local>
In-Reply-To: <220126.86tudqeduk.gmgdl@evledraar.gmail.com>

On Wed, Jan 26, 2022 at 04:04:37PM +0100, Ævar Arnfjörð Bjarmason wrote:
>
> On Tue, Jan 25 2022, Taylor Blau wrote:
>
> I left a comment on 3/9, but re $subject: It really suggests we're just
> refactoring some code to a function ("extract"...), but really we're
> using the new trace2 event added earlier here to test things in a new
> way.

I can see what you're saying. I'd rather not squash the two patches
together (because it makes sense to me as-is, and I'd much rather get
this bug fixed than split hairs on the patch structure), but if you feel
strongly I would do it.

Thanks,
Taylor