From: Josh Steadmon <steadmon@google.com>
Date: Fri, 14 Jan 2022 03:52:07 GMT
Subject: Re: [PATCH] t/gpg: simplify test for unknown key
Message-ID: <YeDzZ1utGGc2ifrC@google.com>
In-Reply-To: <20220107091432.581225-1-fs@gigacodes.de>

On 2022.01.07 10:14, Fabian Stelzer wrote:
> To test for a key that is completely unknown to the keyring we need one
> to sign the commit with. This was done by generating a new key and not
> add it into the keyring. To avoid the key generation overhead and
> problems where GPG did hang in CI during it, switch GNUPGHOME to an
> empty directory instead, therefore making all used keys unknown for this
> single `verify-commit` call.
> 
> Reported-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> Signed-off-by: Fabian Stelzer <fs@gigacodes.de>
> ---
> This was reported by Ævar in <211222.86ilvhpbl0.gmgdl@evledraar.gmail.com>.
> Just using an empty keyring / gpg homedir should achieve the same effect and 
> keeps the stress of generating a gpg key out of the CI.

Looks good to me.

Reviewed-by: Josh Steadmon <steadmon@google.com>