From: Fernando Ramos Date: Sat, 04 Dec 2021 08:31:58 GMT Subject: Re: [PATCH v3 2/3] vimdiff: add tool documentation Message-ID: In-Reply-To: <211201.86ee6w9fq8.gmgdl@evledraar.gmail.com> On 21/12/01 10:27PM, Ævar Arnfjörð Bjarmason wrote: > > > +merge_cmd_help() { > > + case "$1" in > > + *) > > + echo "Run 'man git-mergetool--vimdiff' for details" > > + ;; > > + esac > > + > > + return 0 > > +} > > + > > + > > Isn't the case/esac in those functions entirely redundant and they could > just "echo"? Yes, I originally left it here in case we wanted to print different messages for different variants (vimdiff, vimdiff2, ...). But now that the documentation has been placed into a single file, I don't see a reason to keep this. I'll remove it. Thanks for noticing.