From: Jeff King <peff@peff.net>
Date: Wed, 27 Oct 2021 09:06:28 GMT
Subject: Re: [PATCH v2] Fix "commit-msg" hook unexpectedly called for "git pull --no-verify"
Message-ID: <YXkWlKVVUM9guAhe@coredump.intra.peff.net>
In-Reply-To: <YXjzGzcXS/zPgk0W@pflmari>

On Wed, Oct 27, 2021 at 08:35:07AM +0200, Alex Riesen wrote:

> The option is incorrectly translated to "--no-verify-signatures",
> which causes the unexpected effect of the hook being called.
> And an even more unexpected effect of disabling verification
> of signatures.
> 
> The manual page describes the option to behave same as the similarly
> named option of "git merge", which seems to be the original intention
> of this option in the "pull" command.

Thanks, this looks good to me.

-Peff