From: Jeff King <peff@peff.net>
Date: Mon, 01 Nov 2021 04:04:57 GMT
Subject: Re: What's cooking in git.git (Oct 2021, #06; Mon, 25)
Message-ID: <YX9naXglQIDYa0jg@coredump.intra.peff.net>
In-Reply-To: <1575aeb5-7aec-3d5c-6b2c-11b9866f3f4c@gmail.com>

On Mon, Nov 01, 2021 at 12:06:20AM +0530, Kaartic Sivaraam wrote:

> > This commit has an extra unused parameter in the helper function. I
> > think we'd want the patch below on top.
> > 
> 
> Sorry for the oversight and thanks for catching it (again)!
> 
> This reminded me to check my config.mak and enable DEVELOPER=1
> which I seem to have turned off for some reason. I did notice
> we explicitly add -Wno-unused-parameter to DEVELOPER_CFLAGS (likely
> with good reason). The rest of the flags should be helpful though :)

Yes, there are hundreds of false positives for -Wunused-parameter. I
have a series annotating all of them (which is indeed how I found the
problem fixed here), but I haven't quite gotten around to cleaning them
all up. (Plus I've been a little afraid to flood the list with them).

-Peff