From: Taylor Blau Date: Thu, 09 Sep 2021 02:49:58 GMT Subject: Re: [PATCH v2 0/3] prevent opening packs too early Message-ID: In-Reply-To: <87pmtifp2e.fsf@evledraar.gmail.com> On Thu, Sep 09, 2021 at 04:36:17AM +0200, Ævar Arnfjörð Bjarmason wrote: > Also: That avar-tb/idx-rename-race-3 has a bug where I didn't update the > bulk-checkin.c code accordingly, missed it because I was running a glob > of tests that included "*pack*,*rev*", but missed "*large*". I've got a > avar-tb/idx-rename-race-4 which fixes it. Sorry about that. > > https://github.com/git/git/compare/master...avar:avar-tb/idx-rename-race-4 Yep, I noticed the same thing while running make test on the series before sending it out. Your fix matches mine (which is to move the change from 7/8 to 2/8). While I was fixing the second patch, I inserted a new one just before it to store the hash in a `unsigned char hash[GIT_MAX_RAWSZ]` instead of a `struct object_id`. Thanks, Taylor