From: Taylor Blau <me@ttaylorr.com>
Date: Thu, 26 Aug 2021 03:09:58 GMT
Subject: Re: [PATCH 3/6] tr2: stop leaking "thread_name" memory
Message-ID: <YScGBj4RJP7iISGp@nand.local>
In-Reply-To: <patch-3.6-1fa1bbb6743-20210825T231400Z-avarab@gmail.com>

On Thu, Aug 26, 2021 at 01:19:21AM +0200, Ævar Arnfjörð Bjarmason wrote:
> Fix a memory leak introduced in ee4512ed481 (trace2: create new
> combined trace facility, 2019-02-22), we were doing a free() of other
> memory allocated in tr2tls_create_self(), but not the "thread_name"
> "strbuf strbuf".

Your patch is obviously correct, but is "strbuf strbuf" a typo for
"struct strbuf"? It doesn't really matter, and it certainly is not worth
re-submitting 6 patches for a single typo, but just curious.

Thanks,
Taylor