From: Jeff King <peff@peff.net>
Date: Mon, 16 Aug 2021 16:18:52 GMT
Subject: Re: [PATCH] ci: add job for gcc-4.8 to GitHub Actions
Message-ID: <YRqP7J7Gu0VmB6q2@coredump.intra.peff.net>
In-Reply-To: <444e7410-c9c9-1b90-da5f-d6862a35c1fc@gmail.com>

On Mon, Aug 16, 2021 at 12:06:46PM -0400, Derrick Stolee wrote:

> Forgive me, I probably missed a discussion about this
> somewhere else on the list, but...
> 
> Could you describe why we want GCC 4.8 in our CI? Is that a
> compiler version that we officially support? What kind of
> syntax triggers a problem on 4.8 versus latest?

Try fb9d7431cf (travis-ci: build with GCC 4.8 as well, 2019-07-18).
(found with "git log -Sgcc-4.8 ci"). The gist of it is to find variable
declarations in for-loops.

IMHO it may be more trouble than it's worth. If we can't find a compiler
that complains on this construct, then maybe it is not a construct worth
worrying too much about.

-Peff