From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Tue, 13 Jul 2021 00:10:29 GMT
Subject: Re: [PATCH v2] rev-list: add option for --pretty=format without header
Message-ID: <YOzZ9Zzv+NJu7Wo8@camp.crustytoothpaste.net>
In-Reply-To: <CAP8UFD2BVba_vsXaTPkXgYDGg28xApoyDrrT2fdTddvM1_3CiA@mail.gmail.com>

On 2021-07-12 at 07:30:33, Christian Couder wrote:
> Usually we use "option" instead of "argument" for the flags starting
> with "-" or "--" before the required parameter. For example:
> 
> $ git rev-list -h
> usage: git rev-list [OPTION] <commit-id>... [ -- paths... ]
> ...
> 
> (Yeah, I agree that [OPTION] is not very consistent with what other
> commands show, which is usually "[<options>]".)

I can do that rename.

> test_pretty() accepts options like --no-commit-header, but it's only
> used without any option. So I wonder if you forgot to add a few tests
> with some options.

I originally intended to add some, but decided to remove them because
the --abbrev tests fit better elsewhere.  I'll remove the options.
-- 
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA