From: Jeff King Date: Thu, 24 Jun 2021 19:42:35 GMT Subject: Re: [PATCH 2/4] commit-graph: rewrite to use checksum_valid() Message-ID: In-Reply-To: <64aa0aecbd977a6915c271b9c3c1da3c5043e01d.1624473543.git.me@ttaylorr.com> On Wed, Jun 23, 2021 at 02:39:09PM -0400, Taylor Blau wrote: > Rewrite an existing caller in `git commit-graph verify` to take > advantage of checksum_valid(). > > Note that the replacement isn't a verbatim cut-and-paste, since the new > function avoids using hashfile at all and instead talks to the_hash_algo > directly, but it is functionally equivalent. Yay. IMHO the result is much nicer, as we do not have to wonder about open() returning an error. -Peff