From: Jeff King Date: Wed, 16 Jun 2021 10:24:32 GMT Subject: Re: [PATCH] test-lib: fix "$remove_trash" regression and match_pattern_list() bugs Message-ID: In-Reply-To: On Wed, Jun 16, 2021 at 06:23:07AM -0400, Jeff King wrote: > But this also means the shell will do the usual globbing for each > argument, which can result in us seeing an expansion based on what's in > the filesystem, rather than the real pattern. For example, if I have the > path "t5000" in the filesystem, and you feed the pattern "t?0000", that > _should_ match the string "t0000", but it won't after the shell has > expanded it to "t5000". Whoops, that pattern should be "t?000", of course. It's correct in the runnable example later on. -Peff