From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Thu, 13 May 2021 23:54:35 GMT
Subject: Re: [PATCH 1/2] doc: add an option to have Asciidoctor build man pages directly
Message-ID: <YJ28O7kBwyo4ucOC@camp.crustytoothpaste.net>
In-Reply-To: <117a0b3b-ae7a-ffe7-feee-ae659c588920@gmail.com>

On 2021-05-12 at 04:43:14, Bagas Sanjaya wrote:
> It is customary for multi-patches patch series to have a cover letter.
> For example, when I send a patch that add corrections to an existing
> patch series, I can add permalink of that series' cover letter to be
> clear that my patch is applied on top of another patch series.

I often send one, but I didn't think one was necessary in this case.
I'll send one for v2, since I need to reroll.

> > diff --git a/Makefile b/Makefile
> > index 93664d6714..cb75dec314 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -285,6 +285,9 @@ all::
> >   # Define USE_ASCIIDOCTOR to use Asciidoctor instead of AsciiDoc to build the
> >   # documentation.
> >   #
> > +# Define USE_ASCIIDOCTOR_MANPAGE to use Asciidoctor's manual page backend
> > +# instead of building manual pages from DocBook.
> > +#
> 
> Does USE_ASCIIDOCTOR_MANPAGE imply USE_ASCIIDOCTOR?

It does not, any more than ASCIIDOCTOR_EXTENSIONS_LAB implies that.  I
will update the documentation.
-- 
brian m. carlson (he/him or they/them)
Houston, Texas, US