From: Jeff King <peff@peff.net>
Date: Fri, 23 Apr 2021 14:27:24 GMT
Subject: Re: [PATCH v2 4/6] object-store.h: move read_loose_object() below 'struct object_info'
Message-ID: <YILZTDzMoOVgy6El@coredump.intra.peff.net>
In-Reply-To: <patch-4.6-81fffefcf99-20210413T093734Z-avarab@gmail.com>

On Tue, Apr 13, 2021 at 11:43:07AM +0200, Ævar Arnfjörð Bjarmason wrote:

> Move the definition of read_loose_object() below "struct
> object_info". In the next commit we'll add a "struct object_info *"
> parameter to it, moving it will avoid a forward declaration of the
> struct.

This is a declaration, not a definition, no?

Not a huge deal, I just expected to see the function body moving when I
read the patch, but didn't.

-Peff