From: Jeff King Date: Mon, 29 Mar 2021 09:16:55 GMT Subject: Re: [PATCH 6/7] object tests: add test for unexpected objects in tags Message-ID: In-Reply-To: <8735wfnv7i.fsf@evledraar.gmail.com> On Sun, Mar 28, 2021 at 05:39:45PM +0200, Ævar Arnfjörð Bjarmason wrote: > > I thought the "blind spot" you meant was not testing these cases. But I > > guess you mean that we are not checking stderr. > > > > So OK, but... > > Ah yes. I'll clarify that. I thought it was clear since the series is > about the output we emit on errors, not the rev-list traversal itself. TBH, I think it was as much a reading comprehension fail on my part. But it certainly doesn't hurt to make the commit message more clear. -Peff