From: Jeff King <peff@peff.net>
Date: Wed, 17 Mar 2021 17:42:23 GMT
Subject: Re: [PATCH] t5606: run clone branch name test with protocol v2
Message-ID: <YFI/fxqUoBeCINgv@coredump.intra.peff.net>
In-Reply-To: <20210317154200.2656837-1-jonathantanmy@google.com>

On Wed, Mar 17, 2021 at 08:42:00AM -0700, Jonathan Tan wrote:

> 4f37d45706 ("clone: respect remote unborn HEAD", 2021-02-05) introduces
> a new feature (if the remote has an unborn HEAD, e.g. when the remote
> repository is empty, use it as the name of the branch) that only works
> in protocol v2, but did not ensure that one of its tests always uses
> protocol v2, and thus that test would fail if
> GIT_TEST_PROTOCOL_VERSION=0 (or 1) is used. Therefore, add "-c
> protocol.version=2" to the appropriate test.
> 
> (The rest of the tests from that commit have "-c protocol.version=2"
> already added.)

Thanks, this looks like the obvious and correct fix (and clearly makes
the test pass ;) ).

-Peff