From: Jeff King Date: Fri, 26 Mar 2021 04:22:41 GMT Subject: Re: [PATCH] daemon: sanitize all directory separators Message-ID: In-Reply-To: <314451a4-ee8f-fb68-016f-66a4f3bea409@web.de> On Thu, Mar 25, 2021 at 05:21:24PM +0100, René Scharfe. wrote: > When sanitizing client-supplied strings on Windows, also strip off > backslashes, not just slashes. > [...] > static void sanitize_client(struct strbuf *out, const char *in) > { > for (; *in; in++) { > - if (*in == '/') > + if (is_dir_sep(*in)) Yeah, this seems like the obviously correct thing to be doing. -Peff