From: Taylor Blau <me@ttaylorr.com>
Date: Thu, 11 Feb 2021 02:35:32 GMT
Subject: Re: [PATCH 4/9] midx: keep track of the checksum
Message-ID: <YCSX9FeUu17v13Al@nand.local>
In-Reply-To: <d03263c7-56d3-575c-4ab7-56a617daf34a@gmail.com>

On Wed, Feb 10, 2021 at 09:33:36PM -0500, Derrick Stolee wrote:
> On 2/10/21 6:02 PM, Taylor Blau wrote:
> > +	unsigned char midx_hash[GIT_MAX_RAWSZ];
>
> I was initially thinking we should use something like
> 'struct object_id' here, but the hash we are storing
> doesn't correspond to an object, which would be
> confusing. I suppose this is the most correct thing
> to do.

Yeah. There are a number of places that abuse the unsigned char array
inside of object_id, but there's no good reason to.

Thanks,
Taylor