From: Jeff King Date: Fri, 29 Jan 2021 01:06:11 GMT Subject: Re: [PATCH v3 00/10] pack-revindex: introduce on-disk '.rev' format Message-ID: In-Reply-To: On Mon, Jan 25, 2021 at 06:37:09PM -0500, Taylor Blau wrote: > Here is a third reroll of my series to introduce an on-disk format for the > reverse index. Since the first series (to introduce a new API) has been merged > to 'next', this series has been rebased onto 'next', too. > > This version is largely unchanged from the previous, with the following > exceptions: Thanks, these all seemed like improvements to me. I hadn't read carefully through the test patches yet, so I did so now (in addition to checking out the changes in the earlier patches). My comments range between "musings" and "suggestions". I wouldn't be too torn up if they are all discarded and this applies as-is, but in aggregate there may be enough to merit one more re-roll. -Peff