From: Jeff King <peff@peff.net>
Date: Tue, 26 Jan 2021 22:55:21 GMT
Subject: Re: Null pointer dereference in error pathway on git pull
Message-ID: <YBCd2ZAumP65yrUK@coredump.intra.peff.net>
In-Reply-To: <1cda3398-7b02-edc5-aaab-c75191124b80@cedaron.com>

On Tue, Jan 26, 2021 at 12:31:30PM -0800, Joshua Hudson wrote:

> >git pull
> remote: Azure Repos
> remote: Found 452 objects to send. (157 ms)
> Rfatal: the remote end hung up unexpectedly
> fatal: early EOFs:  81% (367/452)
> fatal: index-pack failed
> warning: unable to unlink '(NULL)': Invalid argument
> 
> 
> So it hits some kind of error (looks like network disconnect) and tries
> to back out; passed a NULL pointer to unlink().
> 
> Apologies if this has been submitted before. A search didn't find it.

Which version of Git are you using? It sounds like the same bug fixed by
6031af387e (fetch-pack: disregard invalid pack lockfiles, 2020-11-30).
That's in v2.30.0.

-Peff