From: Jeff King <peff@peff.net>
Date: Sun, 17 Jan 2021 16:48:54 GMT
Subject: Re: [PATCH] test-lib: add tests for test_might_fail
Message-ID: <YARqdkrxJEW79PYQ@coredump.intra.peff.net>
In-Reply-To: <20210116144147.14036-1-avarab@gmail.com>

On Sat, Jan 16, 2021 at 03:41:47PM +0100, Ævar Arnfjörð Bjarmason wrote:

> > The title confuses me. Isn't might_fail like "must_fail ok=success"?
> >
> > And certainly the code here shows us expecting the _opposite_ of what
> > "Must_fail ok=" does.
> 
> Yes, this made no sense. Here's a sensibe test.
> 
> Junio: This is a stand-alone patch now. I'm splitting this off from my
> WIP v2 of the "set -o pipefail" series.

OK, I'm glad I wasn't just missing something. :) This one makes sense to
me, and seems like a reasonable thing to be checking.

-Peff