From: Jeff King Date: Sun, 17 Jan 2021 16:47:41 GMT Subject: Re: [PATCH v2 06/11] git-svn tests: rewrite brittle tests to use "--[no-]merges". Message-ID: In-Reply-To: <20210116153554.12604-7-avarab@gmail.com> On Sat, Jan 16, 2021 at 04:35:49PM +0100, Ævar Arnfjörð Bjarmason wrote: > From: Jeff King > > Rewrite a brittle tests which used "rev-list" without "--[no-]merges" > to figure out if a set of commits turned into merge commits or not. > > Signed-off-by: Jeff King > Signed-off-by: Ævar Arnfjörð Bjarmason > Commit-message-by: Ævar Arnfjörð Bjarmason Thanks for picking this up. I think it's a cleanup worth doing. I didn't actually sign-off the original I sent, though. I'm quite happy to do so now, and in general everything I send to the list as a "something like this" patch will be done with the intent that it could be contributed under the DCO. But I think in such a case, we should stop short of forging the signoff. And ideally get an explicit signoff, or lacking that just add your own to assert DCO's paragraph (b). Anyway, this is most definitely: Signed-off-by: Jeff King -Peff