From: Jeff King <peff@peff.net>
Date: Fri, 15 Jan 2021 09:36:21 GMT
Subject: Re: [PATCH 1/6] test-lib: add tests for test_might_fail
Message-ID: <YAFiFW7D1qD7ZJ8I@coredump.intra.peff.net>
In-Reply-To: <20210114233515.31298-2-avarab@gmail.com>

On Fri, Jan 15, 2021 at 12:35:10AM +0100, Ævar Arnfjörð Bjarmason wrote:

> +test_expect_success 'test_might_fail is like test_must_fail ok=' '
> +	! test_must_fail git version &&
> +	! test_must_fail ok= git version &&
> +	test_might_fail git version
> +'

The title confuses me. Isn't might_fail like "must_fail ok=success"?

And certainly the code here shows us expecting the _opposite_ of what
"Must_fail ok=" does.

-Peff