From: Jeff King Date: Sun, 22 Jan 2023 07:50:16 GMT Subject: Re: [PATCH] tree-walk: disallow overflowing modes Message-ID: In-Reply-To: On Sat, Jan 21, 2023 at 10:36:09AM +0100, René Scharfe wrote: > When parsing tree entries, reject mode values that don't fit into an > unsigned int. Seems reasonable. I don't think you can cause any interesting mischief here, but it's cheap to check, and finding data problems earlier rather than later is always good. Should it be s/unsigned int/uint16_t/, though? -Peff