From: Jeff King Date: Sun, 15 Jan 2023 20:09:25 GMT Subject: Re: [PATCH] ci: do not die on deprecated-declarations warning Message-ID: In-Reply-To: On Sat, Jan 14, 2023 at 11:02:32PM -0800, Junio C Hamano wrote: > Junio C Hamano writes: > > > But anyway, let's use CURL_DISABLE_DEPRECATION first to see how it > > goes. > > The "DEVELOPER_CFLAGS += -Wno-error=deprecated-declarations" version > was merged to 'next', only because I wanted to see the commit > cleanly pass the tests (and it does), but I do think in the longer > term (like, before the topic hits 'master'), it probably is better > to do this for everybody, not just for those who use DEVELOPER=Yes. > > So, further patches on top are very much welcomed. So I took a look at just dropping the deprecated bits, and it wasn't _too_ bad. Here's that series. The first two I hope are obviously good. The third one is _ugly_, but at least it punts on the whole "how should we silence this" argument, and it takes us in the direction we'd ultimately want to go. [1/3]: http-push: prefer CURLOPT_UPLOAD to CURLOPT_PUT [2/3]: http: prefer CURLOPT_SEEKFUNCTION to CURLOPT_IOCTLFUNCTION [3/3]: http: support CURLOPT_PROTOCOLS_STR git-curl-compat.h | 8 +++++++ http-push.c | 6 ++--- http.c | 61 +++++++++++++++++++++++++++++++++-------------- http.h | 2 +- remote-curl.c | 28 ++++++++++------------ 5 files changed, 68 insertions(+), 37 deletions(-)