From: Jeff King <peff@peff.net>
Date: Thu, 17 Nov 2022 15:12:27 GMT
Subject: Re: [PATCH] notes: avoid empty line in template
Message-ID: <Y3ZPW/seP0auAtKZ@coredump.intra.peff.net>
In-Reply-To: <166867999215.10813.7408480606700051633.git@grubix.eu>

On Thu, Nov 17, 2022 at 11:13:12AM +0100, Michael J Gruber wrote:

> > I don't mind the consistency here, but what does "wrong structurally"
> > mean? Doesn't the usual removing of duplicate newlines make this amount
> > to the same?
> 
> I am talking about what we present to the user as a template, and that
> contains two newlines. Whether they will be reduced afterwards depends
> on the cleanup policy.

I wondered if this might actually be a non-cosmetic bug, if you could so
something like:

  git notes add --cleanup=only-comments

which would retain the extra newlines. But there is no --cleanup option
for git-notes at all (it always calls strbuf_stripspace() internally).
And there is no "comments only" cleanup mode; it is either "clean
nothing", "clean space but leave comments", or "clean both".

So I think it really is just cosmetic.

-Peff